refactor(navbar): Update the theme to fit the indigo ui design #14144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indigo optimizations were prioritized for this refactor. Changes have been made to accommodate a middle section in order to get closer to the web components implementation, styles now handle empty sections. The navigation bar samples have also been updated to showcase these changes.
desig9stein
added
❌ status: awaiting-test
- Change indigo typography for the title - Update sample not to use size overrides - Fix if statement for actions gap - Make sure atomic components sizes are ok inside the navbar
simeonoff
pushed a commit
that referenced
this pull request
May 14, 2024
author Marin Popov <desig9stein@users.noreply.github.com> 1713513321 +0300 committer Simeon Simeonoff <sim.simeonoff@gmail.com> 1715672415 +0300 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgclLk0Ft1X3ZpjF3Xfm110Vvpid tz48BRY/fqpHJV0XAAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQFwKAyIhApjguWdHcyc/uD9Pzut0nhueFrwKAortqhfyIcgeIh9q/VTp6FGiYTQcN1 4G7hg+DLDuWPzviRZETgY= -----END SSH SIGNATURE----- parent 6e5e587 author Marin Popov <desig9stein@users.noreply.github.com> 1713513321 +0300 committer Simeon Simeonoff <sim.simeonoff@gmail.com> 1715672360 +0300 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgclLk0Ft1X3ZpjF3Xfm110Vvpid tz48BRY/fqpHJV0XAAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQAIHAdY3/k1ycat2H94VFdsg+DETKP1bAtMPufNVZWb+IjpMeZixq/LLiva/FzxyDn gFjPkrZ4wVLCM305Jzmg4= -----END SSH SIGNATURE----- refactor(themes): update indigo themes (#14098) feat(navdrawer): update indigo navdrawer (#14092) feat(switch): implement indigo theme updates (#14089) refactor(navbar): Update the theme to fit the indigo ui design (#14144) fix(navbar): remove hardcoded size since the size 2 is the the same fix(bottom-nav): update disabled colors - fix icon color in dark mode - variables for border top and disabled colors fix(navbar): make sure that the icon in all navbar sections have the same size. test(navbar): fix failing test deps(theming): bump to latest version fix(navbar): remove extra dash from --component-size to fix the icon sizes - make sure that the icon button is size 2 in indigo theme. build(navbar):fix lint errors fix(switch): issue in bootstrap theme
simeonoff
pushed a commit
that referenced
this pull request
May 16, 2024
author Marin Popov <desig9stein@users.noreply.github.com> 1713513321 +0300 committer Simeon Simeonoff <sim.simeonoff@gmail.com> 1715672415 +0300 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgclLk0Ft1X3ZpjF3Xfm110Vvpid tz48BRY/fqpHJV0XAAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQFwKAyIhApjguWdHcyc/uD9Pzut0nhueFrwKAortqhfyIcgeIh9q/VTp6FGiYTQcN1 4G7hg+DLDuWPzviRZETgY= -----END SSH SIGNATURE----- parent 6e5e587 author Marin Popov <desig9stein@users.noreply.github.com> 1713513321 +0300 committer Simeon Simeonoff <sim.simeonoff@gmail.com> 1715672360 +0300 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgclLk0Ft1X3ZpjF3Xfm110Vvpid tz48BRY/fqpHJV0XAAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQAIHAdY3/k1ycat2H94VFdsg+DETKP1bAtMPufNVZWb+IjpMeZixq/LLiva/FzxyDn gFjPkrZ4wVLCM305Jzmg4= -----END SSH SIGNATURE----- refactor(themes): update indigo themes (#14098) feat(navdrawer): update indigo navdrawer (#14092) feat(switch): implement indigo theme updates (#14089) refactor(navbar): Update the theme to fit the indigo ui design (#14144) fix(navbar): remove hardcoded size since the size 2 is the the same fix(bottom-nav): update disabled colors - fix icon color in dark mode - variables for border top and disabled colors fix(navbar): make sure that the icon in all navbar sections have the same size. test(navbar): fix failing test deps(theming): bump to latest version fix(navbar): remove extra dash from --component-size to fix the icon sizes - make sure that the icon button is size 2 in indigo theme. build(navbar):fix lint errors fix(switch): issue in bootstrap theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indigo optimizations were prioritized for this refactor. Changes have been made to accommodate a middle section to get closer to the web components implementation, styles now handle empty sections. The navigation bar samples have also been updated to showcase these changes.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)