Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IgxGrid): Add checks in case cell is no longer in view. #14158

Merged
merged 3 commits into from
May 16, 2024
Merged

fix(IgxGrid): Add checks in case cell is no longer in view. #14158

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c72894
fix(IgxGrid): Add checks in case cell is no longer in view.
Apr 24, 2024
69b3a04
Merge branch 'master' into mkirova/fix-14116
mddragnev May 14, 2024
80f3c60
Merge branch 'master' into mkirova/fix-14116
dkamburov May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions projects/igniteui-angular/src/lib/grids/common/crud.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,13 @@ export class IgxCellCrudState {
// this is needed when we are not using ngModel to update the editValue
// so that the change event of the inlineEditorTemplate is hit before
// trying to update any cell
const cellNode = this.grid.gridAPI.get_cell_by_index(this.cell.id.rowIndex, this.cell.column.field).nativeElement;
const document = cellNode.getRootNode() as Document | ShadowRoot;
const activeElement = document.activeElement as HTMLElement;
activeElement.blur();
const cellNode = this.grid.gridAPI.get_cell_by_index(this.cell.id.rowIndex, this.cell.column.field)?.nativeElement;
let activeElement;
if (cellNode) {
const document = cellNode.getRootNode() as Document | ShadowRoot;
activeElement = document.activeElement as HTMLElement;
activeElement.blur();
}

const formControl = this.grid.validation.getFormControl(this.cell.id.rowID, this.cell.column.field);
if (this.grid.validationTrigger === 'blur' && this.cell.pendingValue !== undefined) {
Expand Down Expand Up @@ -285,7 +288,7 @@ export class IgxCellCrudState {
const args = this.cellEdit(event);
if (args.cancel) {
// the focus is needed when we cancel the cellEdit so that the activeElement stays on the editor template
activeElement.focus();
activeElement?.focus();
return args;
}

Expand Down