Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simple-combo): trigger selectionChanging on input clear - 17.2 #14308

Merged
merged 10 commits into from
Jun 20, 2024
Merged

fix(simple-combo): trigger selectionChanging on input clear - 17.2 #14308

merged 10 commits into from
Jun 20, 2024

Conversation

georgianastasov
Copy link
Contributor

@georgianastasov georgianastasov commented Jun 3, 2024 •
edited
Loading

Closes #14200

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@georgianastasov georgianastasov linked an issue Jun 7, 2024 that may be closed by this pull request
Clearing Simple Combo with input does not trigger selectionChanging #14200
Closed
@georgianastasov georgianastasov mentioned this pull request Jun 14, 2024
Closed
14 tasks
@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 19, 2024
@kacheshmarova kacheshmarova merged commit 257e9c1 into 17.2.x Jun 20, 2024
6 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/fix-14200-17.2 branch June 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

Assignees

@Zneeky Zneeky

Labels
simple-combo version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearing Simple Combo with input does not trigger selectionChanging
4 participants
@georgianastasov @jackofdiamond5 @kacheshmarova @Zneeky