Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Grid - Cannot select deleted row when transactions are in place - master #3456

Merged
merged 14 commits into from Jan 4, 2019
Merged

Fix - Grid - Cannot select deleted row when transactions are in place - master #3456

merged 14 commits into from Jan 4, 2019

Conversation

ViktorSlavov
Copy link
Contributor

Closes #3424.

Additional information (check all that apply):

  • Bug fix

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code

damyanpetev
damyanpetev previously approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zdrawku zdrawku changed the base branch from master to 7.1.x December 18, 2018 14:39
Lipata
Lipata previously approved these changes Jan 2, 2019
View reviewed changes
@dafo dafo self-assigned this Jan 2, 2019
@dafo dafo added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 2, 2019
@ViktorSlavov
Merge branch '7.1.x' into vslavov/grid-select-deleted-master
8cb3825 
# Conflicts:
#	projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts
@ViktorSlavov ViktorSlavov dismissed stale reviews from Lipata and damyanpetev via 8cb3825 January 4, 2019 08:55
@bazal4o bazal4o merged commit 7a90c92 into 7.1.x Jan 4, 2019
@bazal4o bazal4o deleted the vslavov/grid-select-deleted-master branch January 4, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev damyanpetev left review comments

@bazal4o bazal4o Awaiting requested review from bazal4o

Assignees

@dafo dafo

Labels
grid: general grid: row-selection transaction igxTransactionService version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ViktorSlavov @Lipata @damyanpetev @dafo @bazal4o @zdrawku