Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): sending proper foritemsize for vertical virt - master #5049

Merged
merged 12 commits into from Jun 19, 2019
Merged

fix(grid): sending proper foritemsize for vertical virt - master #5049

merged 12 commits into from Jun 19, 2019

Conversation

ChronosSF
Copy link
Member

Closes #4931

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev skrustev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 19, 2019
@skrustev skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 19, 2019
@mpavlinov mpavlinov merged commit 52492df into master Jun 19, 2019
@mpavlinov mpavlinov deleted the sstoychev/proper-row-height-master branch June 19, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpavlinov mpavlinov mpavlinov approved these changes

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

Assignees

@skrustev skrustev

@mpavlinov mpavlinov

Labels
grid: general version: 8.0.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When igxGrid is autosized vertically and contains exactly 10 records, the last record is not fully visible
4 participants
@ChronosSF @mpavlinov @skrustev @zdrawku