Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filtering): Scroll chips before remove #5304 #5515

Merged
merged 15 commits into from Aug 5, 2019

Conversation

astaev
Copy link
Contributor

@astaev astaev commented Jul 25, 2019

Closes #5304

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@tachojelev tachojelev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 29, 2019
@tachojelev
Copy link
Contributor

There seems to be an additional behavior that, which presents itself in not refreshing the filter row entirely when removing a chip:

Steps to reproduce:

  1. Set the grid's width of the Grid Column Groups dev demo to 800px.
  2. Open the Grid Column Groups dev demo.
  3. Click the Filter chip for the ContactTitle column.
  4. Add four condition chips.
  5. Scroll to the right-most chip and remove it with the X icon.

Result: Chips are not rearranged properly.
image

@tachojelev tachojelev added ❌ status: awaiting-test PRs awaiting manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 29, 2019
@DiyanDimitrov DiyanDimitrov self-requested a review August 2, 2019 07:36
@DiyanDimitrov DiyanDimitrov self-requested a review August 2, 2019 15:05
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 2, 2019
@DiyanDimitrov DiyanDimitrov self-requested a review August 5, 2019 07:03
@tachojelev tachojelev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 5, 2019
@DiyanDimitrov DiyanDimitrov merged commit d2b010b into 8.1.x Aug 5, 2019
@DiyanDimitrov DiyanDimitrov deleted the astaev/issue5304-8.1.x branch August 5, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filtering grid: general version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants