Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the type of moduleRef param in attach method #5820

Merged
merged 4 commits into from Sep 18, 2019
Merged

Change the type of moduleRef param in attach method #5820

merged 4 commits into from Sep 18, 2019

Conversation

wnvko
Copy link
Contributor

@wnvko wnvko commented Sep 17, 2019 •
edited

Closes #5798

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@tachojelev tachojelev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 18, 2019
@kdinev kdinev changed the title Change the type of moduleRef param in attache method Change the type of moduleRef param in attach method Sep 18, 2019
@kdinev kdinev merged commit 452fb71 into master Sep 18, 2019
@kdinev kdinev deleted the mvenkov/overlay-attach-to-accept-picked-type branch September 18, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

Assignees

@tachojelev tachojelev

Labels
📈 enhancement overlay 🧰 feature-request version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced Filtering Dialog does not open in TreeGrid/HierarchicalGrid
4 participants
@wnvko @DiyanDimitrov @kdinev @tachojelev