Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grid): create a setter for grid's outlet #7379 #7839

Merged
merged 5 commits into from
Jul 27, 2020
Merged

feat(grid): create a setter for grid's outlet #7379 #7839

merged 5 commits into from
Jul 27, 2020

Conversation

onlyexeption
Copy link
Contributor

@onlyexeption onlyexeption commented Jul 21, 2020 •
edited

Closes #7379

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@DiyanDimitrov
Copy link
Contributor

@MayaKirova, could you please take a look whether you are ok with the changes related to the hierarchical grid?

DiyanDimitrov
DiyanDimitrov reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note for the new property to the changelog.

MayaKirova
MayaKirova previously approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@MayaKirova MayaKirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HierarchicalGrid changes look good to me.

@DiyanDimitrov DiyanDimitrov self-requested a review July 23, 2020 09:01
@astaev astaev added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 27, 2020
@DiyanDimitrov DiyanDimitrov merged commit 3d33f1d into 9.1.x Jul 27, 2020
@DiyanDimitrov DiyanDimitrov deleted the ibarakov/fix-7379-9.1.x branch July 27, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

Assignees

@astaev astaev

Labels
📈 enhancement grid: excel-style-filtering grid: general version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onlyexeption @DiyanDimitrov @MayaKirova @astaev