Update cli for ts modules #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
|
There has been no recent activity and this PR has been marked inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CLI to use TypeScript modules. We need this update as in #1057 we are trying to use dynamic imports in
TSto get to logic that's been delegated to whoever is implementing a given migration. These changes cause build errors and a bunch of tests to go haywire which is expected as we are essentially changing the way we export/import modules across the whole of the CLI.