update to 16 #1120
Merged
update to 16 #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
igx-ts side-nav-auth project throws errors aka
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
IvayloG
reviewed
May 4, 2023
There was a problem hiding this comment.
Regarding 1.
The auth project uses AuthModule.forRoot() and from some version it will require a config object like
AuthModule.forRoot({
config: {
// authority: '',
// redirectUrl: window.location.origin,
// postLogoutRedirectUri: window.location.origin,
// clientId: '',
// scope: 'openid profile email offline_access',
// responseType: 'code',
// silentRenew: true,
// useRefreshToken: true,
// logLevel: LogLevel.Debug,
}
}),
Could be fine with an empty obj as well or some bare min maybe.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -277,7 +277,7 @@ | |||
| case "npm": | |||
| /* passes through */ | |||
| default: | |||
| return `${managerCommand} install ${packageName} --quiet --save`; | |||
| return `${managerCommand} install ${packageName} --force --quiet --save`; | |||
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
IvayloG
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1116
Additional information related to this pull request: