Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Refactor Checkbox, Switch, and Radio #1204

Merged
merged 13 commits into from
May 28, 2024

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented May 16, 2024

Closes #1160
Closes #1161
Closes #1162

@sbayreva sbayreva self-assigned this May 17, 2024
:host(:not([disabled])[invalid]),
:host(:not(:disabled)[invalid]) {
[part~='indicator'] {
stroke: black;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using a hardcoded color?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same reason, no need to expose a new property because it's different just in dark bootstrap theme.

@sbayreva
Copy link

Fluent

CHECKBOX:

  1. For Empty Invalid checkbox when on Hover the tick should be Error 500
  2. Something I've noticed- there is a color style called “ disabled-indeterminate-color” that uses secondary 100, and it is not used with the actual disabled indeterminate state here which is good because the right color is grays.400.

RADIO BUTTON:
All good

SWITCH:
All good

@imincheva
Copy link

Bootstrap:

  • Checkbox: by design
  • Radio: by design
  • Switch: by design

@AnjiManova

This comment was marked as resolved.

@AnjiManova

This comment was marked as resolved.

@AnjiManova

This comment was marked as resolved.

@sbayreva
Copy link

Fluent

CHECKBOX:

  1. For Empty Invalid checkbox when on Hover the tick should be Error 500
  2. Something I've noticed- there is a color style called “ disabled-indeterminate-color” that uses secondary 100, and it is not used with the actual disabled indeterminate state here which is good because the right color is grays.400.

RADIO BUTTON: All good

SWITCH: All good

Fluent

CHECKBOX:

  1. For Empty Invalid checkbox when on Hover the tick should be Error 500
  2. Something I've noticed- there is a color style called “ disabled-indeterminate-color” that uses secondary 100, and it is not used with the actual disabled indeterminate state here which is good because the right color is grays.400.

RADIO BUTTON: All good

SWITCH: All good

Fixed!

desig9stein
desig9stein previously approved these changes May 28, 2024
@simeonoff simeonoff changed the base branch from master to simeonoff/theming-7.0.0 May 28, 2024 08:22
@simeonoff simeonoff merged commit 277aa4a into simeonoff/theming-7.0.0 May 28, 2024
2 of 4 checks passed
@simeonoff simeonoff deleted the didimmova/input-controls branch May 28, 2024 08:23
simeonoff added a commit that referenced this pull request May 28, 2024
…box (#1219)

* Themes: Refactor Checkbox, Switch, and Radio (#1204)

* refactor(nav-drawer): update themes (#1167)

---------

Co-authored-by: Marin Popov <desig9stein@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch component refinement Radio Group component refinement Checkbox component refinement
6 participants