Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-registry): add broadcast channel to sync icons. #1295

Merged
merged 19 commits into from
Aug 6, 2024

Conversation

MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Jul 9, 2024

src/components/icon/icon.registry.ts Outdated Show resolved Hide resolved
src/components/icon/icon.registry.ts Outdated Show resolved Hide resolved
@MayaKirova MayaKirova marked this pull request as ready for review July 29, 2024 11:26
src/components/icon/icon-state.broadcast.ts Outdated Show resolved Hide resolved
src/components/icon/registry/types.ts Show resolved Hide resolved
src/components/icon/icon-state.broadcast.ts Outdated Show resolved Hide resolved
src/components/icon/icon-state.broadcast.ts Outdated Show resolved Hide resolved
rkaraivanov
rkaraivanov previously approved these changes Aug 1, 2024
damyanpetev
damyanpetev previously approved these changes Aug 6, 2024
@damyanpetev damyanpetev dismissed their stale review August 6, 2024 15:57

Actually, will wait on answer from ng PR

@damyanpetev damyanpetev changed the title feat(IgxIconService): POC - Add broadcast channel to sync icons. feat(icon-registry): add broadcast channel to sync icons. Aug 6, 2024
@damyanpetev damyanpetev merged commit 9411385 into master Aug 6, 2024
5 checks passed
@damyanpetev damyanpetev deleted the mkirova/poc-icon-service-sync branch August 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants