fix ios use_frameworks building issue #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for this PR @Kudo! |
|
thanks, @IjzerenHein for the quick update 🚀 |
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Nov 30, 2021
# Why upgrade react-native-shared-element to 0.8.3 for SDK 44. close ENG-2540 # How `et uvm -m react-native-shared-element -c "v0.8.3"` v0.8.3 had just one fix and the risk is low: IjzerenHein/react-native-shared-element#81 # Test Plan android unversioned Expo Go + NCL ios unversioned Expo Go + NCL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as facebook/react-native#29633 (comment), libraries may need to depend on
React-Coreto fix use_frameworks! build errors. please take a look if the change making sense.well, i am actually trying to fix the issue 😁