Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPCompatibility warnings and errors #917

Closed
blackcoder87 opened this issue Feb 4, 2024 · 0 comments · Fixed by #1015
Closed

Fix PHPCompatibility warnings and errors #917

blackcoder87 opened this issue Feb 4, 2024 · 0 comments · Fixed by #1015
Labels
Type: Bug The issue documents broken, incorrect, or confusing behavior.

Comments

@blackcoder87
Copy link
Contributor

blackcoder87 commented Feb 4, 2024 •
edited
Loading

Describe the bug

FILE: /vagrant/application/libraries/Ilch/Validation/Validators/Numeric.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 11 | WARNING | 'numeric' is a soft reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (class declaration)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Support for BBCode is removed with the upgrade to CKEditor 5.

Additional context
https://github.com/IlchCMS/Ilch-2.0/tree/master/development#php-compatibility-coding-standard-for-php-codesniffer-phpcs
@blackcoder87 blackcoder87 added the Type: Bug The issue documents broken, incorrect, or confusing behavior. label Feb 4, 2024
hhunderter added a commit to hhunderter/Ilch-2.0 that referenced this issue Jun 19, 2024
@hhunderter
IlchCMS#917 + BS5 fix
7f3dab8
@hhunderter hhunderter mentioned this issue Jun 19, 2024
Merged
blackcoder87 pushed a commit that referenced this issue Jun 19, 2024
@hhunderter
Php8 support (#984)
edb0392 
* PHP 8 Support + BS5 fix

* #917 + BS5 fix
@blackcoder87 blackcoder87 mentioned this issue Jun 23, 2024
Merged
6 tasks
This was referenced Jul 31, 2024
Merged
Merged
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug The issue documents broken, incorrect, or confusing behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update MysqlCollector used in the DebugBar (PHP 8.4 support) IlchCMS/Ilch-2.0
1 participant
@blackcoder87