Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses GNU and OSX compatible mktemp #39

Merged
merged 4 commits into from
Jan 16, 2020

Conversation

jjzieve
Copy link
Contributor

@jjzieve jjzieve commented Mar 30, 2019

I realized we're assuming GTCtoVCF will be run on Linux systems, especially for production usage. For example, when the README points to the Linux Miniconda install script. But it seems to work fine on Darwin with a couple tweaks to the download_reference.sh script. And users may want to run locally on a Mac if they're just testing it out.

@jjzieve
Copy link
Contributor Author

jjzieve commented Apr 13, 2019

Also forgot I had to run brew install coreutils as well

@jjzieve jjzieve force-pushed the cross-platform-download-reference branch from 9a9d247 to bfff596 Compare January 14, 2020 01:23
Copy link

@CodeWithCare CodeWithCare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I ran it and seems to run fine. I mean no errors and still downloading...

@jjzieve jjzieve merged commit cd8e643 into develop Jan 16, 2020
@jjzieve jjzieve deleted the cross-platform-download-reference branch March 28, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants