Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

add icon for scarpet files #4

Closed
ImUrX opened this issue Mar 23, 2020 · 13 comments
Closed

add icon for scarpet files #4

ImUrX opened this issue Mar 23, 2020 · 13 comments
Labels
enhancement New feature or request

Comments

@ImUrX
Copy link
Owner

ImUrX commented Mar 23, 2020

I need opinions on this matter, the current icon that gnembon got me is
scarpet icon
but its not made for a file icon in vscode.

My current idea was this one
svg icon
(its an svg you can download it and edit it)
based on the idea of a >_ with a carpet, but well

anyone got any other idea?

@ImUrX ImUrX added the help wanted Extra attention is needed label Mar 23, 2020
@ImUrX ImUrX pinned this issue Mar 23, 2020
@ImUrX
Copy link
Owner Author

ImUrX commented Mar 23, 2020

Another proposed design by a friend is something like this polar

@ImUrX
Copy link
Owner Author

ImUrX commented Mar 23, 2020

polar 2 what a genius

@invisiblespider
Copy link

Artboard 1
Artboard 2
Artboard 3
a few designs based on the idea of >_
i thought it would be appropriate to use pink carpet.

@invisiblespider
Copy link

i realize it a bit wide but it just to put out there some ideas

@Ghoulboy78
Copy link
Contributor

image
just an idea to use vscode logos to make the Sc

@ImUrX
Copy link
Owner Author

ImUrX commented Mar 23, 2020

gonna tell you, thanks for the forms of the things but its a good idea to have a limited color palette in this case because it will be repeated multiple times
this is what colors most icons use (intellisense and debug) but if you got a good reason for not using that palette please say so :D

@invisiblespider im intrigued on why the pink carpet?

@ImUrX
Copy link
Owner Author

ImUrX commented Mar 23, 2020

giving another example of how it would look with various icons
example

@invisiblespider
Copy link

invisiblespider commented Mar 23, 2020

it's an indirect reference to the using pink carpet on carpet mod Carpet Mod for Minecraft 1.14/1.15 - Complete Guide

@invisiblespider
Copy link

sc

@ImUrX
Copy link
Owner Author

ImUrX commented Mar 26, 2020

try i tried to recreate the second one with the third one

@ImUrX
Copy link
Owner Author

ImUrX commented Mar 27, 2020

Well will close this at the moment, if anyone has any issues please say so

@ImUrX ImUrX closed this as completed Mar 27, 2020
ImUrX pushed a commit that referenced this issue Mar 27, 2020
Merge pull request #3 from Ghoulboy78/master
@ImUrX ImUrX unpinned this issue Apr 5, 2020
@ImUrX ImUrX added blocked and removed help wanted Extra attention is needed labels Apr 5, 2020
@ImUrX
Copy link
Owner Author

ImUrX commented Apr 5, 2020

So guys, i discovered that this is not possible currently in VSCode microsoft/vscode#14662, but I'm seeing if I can make the PR myself or if something is on the works

@ImUrX ImUrX reopened this Apr 5, 2020
@ImUrX ImUrX changed the title Trying to make an icon for scarpet files Icons aren't possible to add in VS Code independently Aug 25, 2020
@ImUrX ImUrX added enhancement New feature or request and removed blocked labels Mar 3, 2021
@ImUrX ImUrX changed the title Icons aren't possible to add in VS Code independently add icon for scarpet files Mar 3, 2021
@ImUrX
Copy link
Owner Author

ImUrX commented Mar 3, 2021

will implement this when i have time

@ImUrX ImUrX closed this as completed Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants