MSL - authenticate attribute parsing #2779
Unanswered
J0hnnyB0y
asked this question in
Development
Replies: 1 comment 2 replies
-
Thanks for the problem report. We can reproduce it and will have a patch to fix it in the GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ https://www.imagemagick.org/download/beta/ by sometime tomorrow. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi.
I started to have some interest in the MSL support of ImageMagick so I started to read the code. Most of it is quite straightforward but I was wondering about the "authenticate" attribute support:
https://github.com/ImageMagick/ImageMagick/blob/master/coders/msl.c#L8134
if (LocaleCompare(keyword,"authenticate") == 0)
{
(void) CloneString(&image_info->density,value);
break;
}
Why is the defined authenticate value assigned to the density attribute? Isn't this already handled in https://github.com/ImageMagick/ImageMagick/blob/master/coders/msl.c#L8177, which is the density attribute?^^
Shouldn't authenticate handle authenticate eg a password as used in coders/pdf.c or MagickCore/delegate.c?
cheers
Beta Was this translation helpful? Give feedback.
All reactions