Configure HTTPS #35
Configure HTTPS #35
Conversation
There was a problem hiding this comment.
Could you add some documentation explaining the steps used to setup certbot?
Perhaps add this info to the https://github.com/Imageomics/Andromeda#deployment section.
|
README entry added |
| sudo dnf install nginx -y | ||
| sudo systemctl start nginx |
There was a problem hiding this comment.
Is it necessary to temporarily install nginx and run it on the host VM?
What happens if you don't start nginx?
There was a problem hiding this comment.
The alternative to installing nginx on the host is to configure Certbot to work with the Dockerized nginx. Either way would work fine, but if neither is done, Certbot won't be able to validate our control of the domain.
There was a problem hiding this comment.
I think this is ok for now, but could you create an issue to research using the nginx container we are already with certbot:
Andromeda/andromeda-ui/Dockerfile
Line 7 in 6b3f525
Installing nginx in two places could lead to confusion down the road if we need to change an nginx config setting.
There was a problem hiding this comment.
OK, sounds good! Now part of #37.
Co-authored-by: John Bradley <johnbradley2008@gmail.com>
Installed certs with certbot into EC2 instance, mounted volume into docker-compose, and configured nginx to use encryption. Forwards http to https.
Auto cert renewal coming in a future issue.
This branch came directly off of
main, and commits to it were cherry-picked fromhttps(which was branched from15-react) to select only the relevant HTTPS-related changes.