Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/even more seg tests #18

Merged
merged 9 commits into from
Feb 26, 2020
Merged

Feature/even more seg tests #18

merged 9 commits into from
Feb 26, 2020

Conversation

CPBridge
Copy link
Collaborator

More tests for segmentation object creation, particularly for odd numbered pixel data.

Fixed warnings about odd numbered pixel data.

hackermd
hackermd requested changes Feb 22, 2020
View reviewed changes
Copy link
Collaborator

@hackermd hackermd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Including the information about the overlap will be very useful. I have only one comment.

src/highdicom/seg/enum.py Outdated Show resolved Hide resolved
@hackermd hackermd self-assigned this Feb 22, 2020
@hackermd hackermd added the enhancement New feature or request label Feb 22, 2020
@hackermd hackermd merged commit 6678bde into master Feb 26, 2020
@hackermd hackermd deleted the feature/even_more_seg_tests branch February 26, 2020 22:37
@Marsxpc Marsxpc mentioned this pull request Jun 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackermd hackermd hackermd approved these changes

Assignees

@hackermd hackermd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CPBridge @hackermd