fix: Remove unneeded importlib metadata dependency #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the `importlib.metadata.distribution()` function is available in Python 3.8 and 3.9 where it is implemented in `Lib/importlib/metadata.py` and not `Lib/importlib/metadata/__init__.py`.
jcfr
force-pushed
the
remove-unneeded-importlib_metadata-dependency
branch
from
f9834e2
to
504852a
Compare
|
@vkt1414 If you approve the pull request, now that we have the possibility to enable
I also just added you a reviewed. For context, I initially assigned the issue to you instead of adding you as a reviewer. |
|
thank you, @jcfr ! We are still learning how the pyproject.toml is put together. So, as long as the checks are working, we are okay! |
vkt1414
approved these changes
Mar 29, 2024
jcfr
changed the title
jcfr
changed the title
fedorov
added a commit
to ImagingDataCommons/idc-index
that referenced
this pull request
Apr 12, 2024
`importlib.metadata.distribution()` is available with python >= 3.8 The check for python 3.10 broke SlicerIDCExtension, since Slicer is using 3.9 Related to ImagingDataCommons/idc-index-data#12 --------- Co-authored-by: Vamsi Thiriveedhi <vthiriveedhi@mgh.harvard.edu> bugg
fedorov
added a commit
to ImagingDataCommons/idc-index
that referenced
this pull request
Apr 12, 2024
`importlib.metadata.distribution()` is available with python >= 3.8 The check for python 3.10 broke SlicerIDCExtension, since Slicer is using 3.9 Related to ImagingDataCommons/idc-index-data#12 --------- Co-authored-by: Vamsi Thiriveedhi <vthiriveedhi@mgh.harvard.edu>
fedorov
added a commit
to ImagingDataCommons/idc-index
that referenced
this pull request
Apr 13, 2024
`importlib.metadata.distribution()` is available with python >= 3.8 The check for python 3.10 broke SlicerIDCExtension, since Slicer is using 3.9 Related to ImagingDataCommons/idc-index-data#12 --------- Co-authored-by: Vamsi Thiriveedhi <vthiriveedhi@mgh.harvard.edu> Co-authored-by: Jean-Christophe Fillion-Robin <jcfr@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded importlib_metadata dependency with Python < 3.10
It turns out that the
importlib.metadata.distribution()function is available in Python 3.8 and 3.9 where it is implemented inLib/importlib/metadata.pyand notLib/importlib/metadata/__init__.py.For more details: