feat: add secondary dicom server #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrokohler instead of using it like: Update it so we use like: This way people can decide which healthcare api to use e.g. v1 or v1beta1 etc. |
igoroctaviano
requested changes
Feb 8, 2024
|
@pedrokohler please address linting step which is failing |
pedrokohler
force-pushed
the
feat-secondary-server
branch
from
76fa415
to
9d4e643
Compare
@igoroctaviano done. |
github-actions bot
pushed a commit
to igoroctaviano/slim
that referenced
this pull request
May 2, 2024
# [0.2.0](v0.1.1...v0.2.0) (2024-05-02) ### Bug Fixes * **package.json:** Fix Inefficient Regular Expression Complexity in nth-check (vulnerability) ([ImagingDataCommons#151](https://github.com/igoroctaviano/slim/issues/151)) ([4f42258](4f42258)) * security issues ([ImagingDataCommons#179](https://github.com/igoroctaviano/slim/issues/179)) ([eb8ddc0](eb8ddc0)) * **test.txt:** testing release ([00aabd6](00aabd6)) ### Features * add secondary dicom server ([ImagingDataCommons#188](https://github.com/igoroctaviano/slim/issues/188)) ([356009f](356009f))
github-actions bot
pushed a commit
to igoroctaviano/slim
that referenced
this pull request
May 2, 2024
# [0.2.0](v0.1.1...v0.2.0) (2024-05-02) ### Bug Fixes * **package.json:** Fix Inefficient Regular Expression Complexity in nth-check (vulnerability) ([ImagingDataCommons#151](https://github.com/igoroctaviano/slim/issues/151)) ([4f42258](4f42258)) * security issues ([ImagingDataCommons#179](https://github.com/igoroctaviano/slim/issues/179)) ([eb8ddc0](eb8ddc0)) * **test.txt:** testing release ([00aabd6](00aabd6)) ### Features * add secondary dicom server ([ImagingDataCommons#188](https://github.com/igoroctaviano/slim/issues/188)) ([356009f](356009f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to use a secondary annotations server passed in the url with the gcp query parameter.
Solves #186
Before:
Only one server allowed.
After:
Screenshare.-.2024-02-02.11_23_44.AM.mp4