Fix click #14
Fix click #14
Conversation
… for vertices (they check correctly now). Paq.sh now automatically outputs to nuklear.h.
keharriso's Prevent clicking more than one (overlapping) button per frame. However, this has a couple of other changes that should fix dropdowns from intefering as well.
- Sets click to 0 every start of frame - Input was still down for that frame, so it triggered the next event Now it waits for your button to go back up before resetting the clicked variable, so as long as your mouse is down, only one item is clicked.
src/nuklear_button.c
Outdated
| @@ -78,6 +78,8 @@ nk_button_behavior(nk_flags *state, struct nk_rect r, | |||
| #else | |||
| nk_input_is_mouse_pressed(i, NK_BUTTON_LEFT); | |||
| #endif | |||
| if (ret) | |||
There was a problem hiding this comment.
Nitpick: indentation seems off in the whole PR 😉
There was a problem hiding this comment.
There are 3 tabs on that line, but nuklear.h uses spaces for indentation. At best, we should stick with that instead of introducing inconsistencies.
There was a problem hiding this comment.
Fixed, I think.
| @@ -108,7 +110,7 @@ nk_draw_button(struct nk_command_buffer *out, | |||
| } | |||
| NK_LIB int | |||
| nk_do_button(nk_flags *state, struct nk_command_buffer *out, struct nk_rect r, | |||
| const struct nk_style_button *style, const struct nk_input *in, | |||
| const struct nk_style_button *style, struct nk_input *in, | |||
There was a problem hiding this comment.
Removing const here (an other places) is a breaking change in cases where people use -Werror, because users might have written code simular to this:
const struct nk_input *in = ...
...
nk_do_button(state, out, r, style, in, behavior, content)Which would now throw this error:
error: passing 'const struct nk_input *' to parameter of type 'struct nk_input *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
Should the major version be incremented because of this?
There was a problem hiding this comment.
I agree but it's the only straightforward way to fix it.
There was a problem hiding this comment.
Yeah, the missing consts are a pity, but I also don't see any more suitable way to solve it. Maybe we should increase the minor part of the version instead of the bugfix part to emphasize this breaking change (but in the context of the usage of Nuklear, I think this does not deserve a major version bump).
There was a problem hiding this comment.
Hmm. Yea bumping major really is overkill, even though it is consistent with the documentation for the changelog. I think minor bump + emphasis is good enough.
vurtun/nuklear#803
keharriso's Prevent clicking more than one (overlapping) button per frame.
Problem with existing PR was as follows:
Now it waits for your button to go back up before resetting the mouse's clicked variable, so as long as your mouse is down, only one item is clicked.