Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apply_overrides #69

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Add apply_overrides #69

merged 6 commits into from
Feb 27, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Feb 23, 2024

Addresses: #67

Edit:

Going to go with @dalonsoa 's initial suggestion - implicit in this is that parameters are not override-able by default. The more I looked the more I realised that most parameters we probably don't want to be override-able.

@barneydobson
Copy link
Collaborator Author

@dalonsoa I guess not too much here to cause trouble. I don't quite get the failing ruff stuff- since it says maybe it can fix automatically? Is it working differently than pip_tools_template and not automatically doing this at commit?

@dalonsoa
Copy link
Collaborator

It should be doing the very same thing in the CI and in your local copy when making a commit. I guess you have, but just checking: is pre-commit installed and running whenever there's a new commit?

@barneydobson
Copy link
Collaborator Author

Yes it was that - I was using an old wsimod environment

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as the starting point!

The QA is still failing. Follow the suggestions in the errors and force the run of pre-commit in all files. Let's see if that fixes the issue.

@barneydobson barneydobson merged commit 2bad335 into main Feb 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants