Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes installed as composer dependencies #1106

Merged
merged 6 commits into from
Dec 17, 2021
Merged

Themes installed as composer dependencies #1106

merged 6 commits into from
Dec 17, 2021

Conversation

MekDrop
Copy link
Member

@MekDrop MekDrop commented Dec 12, 2021

Both iTheme and core are now loaded as composer dependencies.

Also themes all files are located in ROOT/themes and assets as before in WWW_ROOT/themes.

@MekDrop MekDrop added this to the 2.0.0 Alpha 12 milestone Dec 12, 2021
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 18648 lines exceeds the maximum allowed for the inline comments feature.

@MekDrop MekDrop changed the title Themes from composer Themes installed as composer dependencies Dec 12, 2021
@fiammybe fiammybe merged commit 7d2ef8c into ImpressCMS:master Dec 17, 2021
@MekDrop MekDrop deleted the improvement/use-core-theme-from-composer branch December 17, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants