Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

355 - fix creation of initial user #357

Merged
merged 2 commits into from
Dec 24, 2018

Conversation

fiammybe
Copy link
Member

Regression in the installer due to #333 . Fix #355

Regression in the installer due to #333 . Fix #355
@fiammybe fiammybe added the bug label Dec 23, 2018
@fiammybe fiammybe added this to the 2.0.0 alpha8 milestone Dec 23, 2018
@fiammybe fiammybe self-assigned this Dec 23, 2018
htdocs/install/makedata.php Outdated Show resolved Hide resolved
correcting the XOOPS_URL -> ICMS_URL
@fiammybe fiammybe requested review from skenow and MekDrop and removed request for MekDrop and skenow December 23, 2018 10:45
@fiammybe
Copy link
Member Author

Tested this change, the issue is resolved.
Close #357

Copy link
Contributor

@skenow skenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the fields in the insert statement now lines up with the table schema, resolving the installation issue.

@skenow skenow merged commit ad0f398 into retro Dec 24, 2018
@MekDrop MekDrop deleted the fiammybe-fix-355-installer-regression branch April 9, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants