Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version "latest" is problematic #210

Closed
dominikheinz opened this issue Dec 28, 2022 · 6 comments
Closed

Version "latest" is problematic #210

dominikheinz opened this issue Dec 28, 2022 · 6 comments
Labels
enhancement New feature or request low priority This issue is a low priority (the dev may not work on it but PRs are welcome)

Comments

@dominikheinz
Copy link

Some apps on GitHub use (unfortunately) not proper version labeling.
For example: https://github.com/crackededed/Xtra

It specifies installed version as latest and remote version also as latest. But I know for a fact that the installed version is older. What is the best way to handle this? Maybe checking the date or something...?

@ImranR98
Copy link
Owner

ImranR98 commented Dec 28, 2022

Using release dates instead of release titles would not work easily as Obtainium needs to be able to compare the actual App version to the external one - so there would need to be a lot of under the hood changes. Also unlike version numbers, not all sources would make release dates available, so there would have to be completely different update checking logic just for specific Apps from some sources (and the user would have to manually specify them as I don't see how it can be done automatically). Would also need to avoid conflicting with the existing version detection toggle.

I don't think it's worth supporting at this point as only a small number of Apps do releases this way. That said, the issue should remain open in case it does get picked up at some point.

@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2022
@ImranR98 ImranR98 reopened this Dec 28, 2022
@ImranR98 ImranR98 added enhancement New feature or request low priority This issue is a low priority (the dev may not work on it but PRs are welcome) labels Dec 28, 2022
@dominikheinz
Copy link
Author

That's fair. So the best option is to suggest to the developer to switch to proper versioning numbers?

@ImranR98
Copy link
Owner

Yes that would be the solution for now

@sertonix
Copy link

sertonix commented Feb 13, 2023

Currently the detection for versions of Etar also doesn't work.
I created an issue there to make the naming consistend.
Etar-Group/Etar-Calendar#1338

Edit: the issue was rejected

@ImranR98
Copy link
Owner

ImranR98 commented Feb 17, 2023

Leaving some notes for later:

  1. Add Date? releaseDate to App schema.
  2. Modify Sources to grab release dates (for any Sources where this is doable).
  3. Add an toggle to additionalAppSpecificSourceAgnosticSettingFormItems to enable using the App release date as the App version.
  4. In the UI, add a prompt explaining the limitations of this method to the user (similar to what is being done for track-only).
  5. When releaseDateAsVersion == true, noVersionDetection should automatically be enabled too (since version detection won't work when using dates as versions). Figure out the best place this logic should be added.
  6. Modify the code to respect this new toggle by replacing the version string with an integer representing the release date (discard original version strings). Again, do this in an appropriate place.
  7. In the UI (both Apps List and App Detail), add the Release Date for Apps that support it (along with a sort option) - this is for Add date along with version in app list, and allow sorting by date. #298.

ImranR98 added a commit that referenced this issue Feb 19, 2023
Release Date Support for Some Sources (#210 + #298) + UI Changes (#274) + Bugfix (#299)
@ImranR98
Copy link
Owner

Using release dates instead of versions is now supported (for some Sources): https://github.com/ImranR98/Obtainium/releases/tag/v0.11.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority This issue is a low priority (the dev may not work on it but PRs are welcome)
Projects
None yet
Development

No branches or pull requests

3 participants