New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha 0.6.2-8 Feedback #60
Comments
During the initial install all switch to 0.6.2 two apps gave an error to the effect of, unable to update as a newer version is not available (I can't remember the exact wording ). https://github.com/darshan-/Battery-Indicator-Pro (Github release is behind F-droid version) Marking apps as up to date resolved this issue. |
Will test update checking in the week. |
Thanks for the feedback! Some points to note:
If there are any more unexpected errors, please take a screenshot or copy/paste. |
I think you misunderstood my feedback a bit but no worries the issues I shared were not bugs so much as side effects of switching to the new detect method. EG: I didn't add F-droid as a source in Obtanium. I did have https://github.com/darshan-/Battery-Indicator-Pro as a source in my Obtanium app list. Fdroid has v12 of battery indicator hosted while github releases only has v10. So that's why Obtanium couldn't update it. |
Can't do that as we don't know what the real version of an App is until the APK is downloaded. The version displayed in the App is a version string from GitHub, which may be different. So we can't compare the two until install time. |
Okay, it's no big issue at least |
Not sure if anyone else has encountered this, sometimes Apps say update available even though there isn't, because the version string gets overwritten. Only happens in the background process (of course). Not sure why yet, and it doesn't happen consistently. will have to look into it. |
Small improvements, still haven't fixed the issue above (or know what causes it) but it should happen with fewer Apps: app-release-0.6.3-beta.zip |
Testing update notifications without launching the app: Monday I was on wifi all day and got no notifications. I know there was one update available half way through the day. Yesterday (Tuesday) I had Wifi on most of the day. At some point I saw a notification 'checking for updates' but around the same time I lost signal. When I got signal again the notification quickly changed to 'error checking for updates, failed to lookup api.github.com' But it seems only because the vpn was still connecting. This seems to happen every time, then the update only checks again three hours later. This morning I turned on the phone and got a 'Checking for updates' notification but shortly after putting on Wi-fi and just after the VPN was connecting and did in fact connect: 'Error checking for updates connection refused' This is related to Issue #47 |
I'll install 0.6.3 and keep testing |
On 0.6.3 Yesterday I had wifi on all day with no notification. Last night I turned off Wi-fi but left the phone on. |
I just got a checking for updates 🔔 |
Just got a 🔔 'Error checking for updates - Connection refused' |
Yep, I've also had this twice now with perfectly working connection. It also seems to cause that issue I mentioned earlier. Can't seem to reproduce the issue in the dev emulator though, very frustrating. |
Sometimes it's 'hostname not found', sometimes something like 'software connection abort', and apparently it can be 'connection refused' too. Seemingly always in the background update checking. |
Hmm… what can I test for you? I have only tested background updates without launching the app so far, should I test launching and refreshing? |
Not sure tbh. There's no reason to get a connection error when there is an active internet connection, so I'm not sure what the problem is (maybe related to #55). I guess we could just quietly handle these errors by waiting 15 minutes and trying again (like it already handles rate limit errors), but there are 3 different error objects to track down so that will be tricky. In the meantime, there's a new release which hopefully fixes that version string issue I ran into earlier: app-release-0.6.4.zip |
The thing is the current release (non alpha) was notifying successfully in the background. So maybe it's worth testing 0.6 a bit longer |
I opened Obtanium now and had a number of updates to do. PS: a reboot is required between exports and imports or the app fails to update, you may want to automate this or give a warning. PPS I changed the update interval to 2hours for future testing. I know the current issues may be frustrating but don't stress, the app is doing great so far. |
Interesting, my notifications and import/export seem to work fine. But I don't have that many Apps, will continue to test. |
Could you give more details about the error you mentioned above? What error did you get when the installs failed, and why wouldn't it let you update without re-importing? Also was this on the latest 0.6.4 |
Slight changes: app-release-0.6.5.zip Might help with some issues |
Was on 0.6.3, the update fail was a silent error but as I said, I think it's isolated incident due to me changing android defaults during install, don't worry about that. "Why wouldn't it let me update without re-importing" I'll update to 0.6.5 now. |
Meanwhile, I'm still having that weird issue with App versions being changed in the background. Only happens on my phone (not the emulator) and only sometimes. Still no clue what causes it but there are a couple small changes in this version that might help: Will see about adding logging to the next release so people who have issues can attach logs and hopefully make it easier to track down bugs. |
So I've had no update notifications lately but opened the app now and without refreshing, I see it shows updates for some apps that Octodroid didn't notify me about so that's nice but it's also showing updates for some apps that were supposedly updated by obtanium already. Namely: Also I keep marking I updated all apps, and got an error in app that I could only read by repeating the process a few times: platform exception invalid package parse error, Storage/emulated/0… LibreCamera APK null I restarted Obtanium, redownloaded updates, and got the same error And updates worked but only 3/6 or so apps actually installed which to me confirms that some of the apps showing updates were actually already updated. Not sure why librecamera won't work. |
Perhaps my Obtanium is also changing app versions in the background and falsely detecting some updates |
Yes, that's the same issue I'm having. Was able to narrow down what happens - the It's most likely happening because I'm using a Flutter plugin to detect installed Apps, and it's possible that plugin works well in the foreground process but not in the background. Worst case I'll just disable that detection for background processes - it should not make a difference for most users. The one downside is that users who uninstall an App between beckground update checks (without opening Obtainium in the foreground at any point) will still be notified of updates for that App even though it is not installed.
Better not to add an App to Obtainium if a different App (F-Droid) is already used to manage it. |
Regarding Librecamera, I just downloaded the APK from GitHub (through the browser) and tried installing it on my phone, and got an "invalid package" error. So it looks like this is not an Obtainium issue. |
Gotta love & hate a good workaround 😅 |
Lol, I'm half expecting it to still fail though 🤦♂️ I've only halfway implemented the originally intended workaround because that avoids the problem mentioned earlier:
Might still have to finish the job and live with that compromise. |
Yep, the problem is still there, I just had to wait a bit longer to see it (been using this version since last night). If you haven't downloaded it don't bother. |
I have… I'm still testing background update checks so not launching the app |
See I got a weird Error 🔔. 26min ago: |
That means the App Source (GitHub I guess) decided to close the connection. It may be a one-off thing. Does it happen every time for that App? |
No, never seen it before |
Ok I promise* it should be fixed with this one: app-release-0.6.8.zip *Maybe |
Haha I'll install now, what did you find/do? By the way just got a failed host lookup api.github 🔔 5min ago |
When Apps load, Obtainium checks to see if they are installed on the phone. If they are, it corrects any discrepancies between the real install status of each App and its internally stored install status. For some reason, this would sometimes fail in the background, causing all Apps to be marked as "not installed". I just disabled that detection and correction for background processes. As for the failed host lookup errors, yeah I get those too sometimes even with a good connection. No idea what the cause is since it seems random. May have to work around those too eventually but since they are not that frequent, I'll release the changes made so far this weekend. |
Okay, I think this is ready for release: app-release-0.6.0-42.zip For some reason Obtainium was using the master branch of Flutter which is unstable (don't remember ever switching to it). so I've switched to the stable branch which should hopefully help with some of the more random glitches. I already noticed some weird UI issues I had are no longer there. It does mean some material UI elements like switches will have the old design again for now, but that will be fixed when those changes come to the stable branch eventually. Also reset the versioning to 0.6.0 as the builds we've been testing (0.6.2-0.6.8) were not actually released. |
Will you release even though background updates worked on 0.5 but haven't once worked for me on 0.6 versions? |
Huh. I thought they worked for you aside from the occasional hostname error. They seem to work for me but definitely can't release if you're not able to update at all. Could you try this new one and let me know. |
I can only update when opening the app all background notifications on these alpha versions have been errors. It may have found the updates for most aops but only ever reported errors. I will test this new version though and its up to you if you release, the app still sees and does the updates when I open it, so it still does it's job |
Hmm, definitely can't release if there's come bug that breaks background checking completely. Maybe it's a specific app you have added because things are fine for me. Anyways try this one and see. |
This comment was marked as outdated.
This comment was marked as outdated.
Great, I'll try that out, maybe I can open JSON files with this: https://github.com/laiiihz/alga/ Was thinking, you probably should add basic logs sometime as you mentioned before and an easy way to submit them. Maybe an email address in the app or link to Github. Cos there are bound to be difficulties getting some apps to update when you're pulling from so many sources. The email could autoreply with FAQs and ask people to let you know if they solved the issue. |
Sorry, uploaded the wrong version, so marked the comment as outdated. Will upload in 5 mins. |
I use Markor but whatever works, |
Also yes, will work on logs. |
Amazingly, not one of the logging plugins I've looked at works in background processes (zubairehman/Flogs#66, umair13adil/flutter_logs#14). It feels like Flutter devs don't think mobile Apps need to do anything in the background since plugins look to be very limited in bg processes 🤦 |
Okay Markor worked, um should I use that new 44 version 👆 Did you already put logs in? You know… long term it may be useful to extend the Github PAT to allow people to browse Github and post issues. That way people can easily give app feedback for you and other developers. I know never used Github until I got this Octodroid app since its convenient and very nice to be able to interact with repo devs. |
Oh I missed that earlier message, I'm installing 44 now |
Alternatively you could add a link to a forum where people can find and give feedback. Or if you want something that doesn't require accounts or apps for user feedback |
Hooray 🚀 It also notified me under non-ideal scenarios because my phone was off wifi most of the morning but when I reconnected to the vpn about twenty minutes ago it struggled to connect at first. Previously obtainium would error notify right away if the vpn was struggling, but now there was only a successful notification after 20min or so. ✨ |
* Fixes #14 (although detection is disabled in background processes due to the bug described in #60) * Added App icons and basic installed detection * Real Package Names Used as IDs + App Icons (INCONVENIENT FOR PREVIOUS VERSION USERS) * Switch to using extracted names (no custom names) * Fixes #57 * Fixes #67 * Fixes #64 * Fixes #61 * Commented out APKMirror and added code to remove their Apps * Updated README * Switched to Flutter stable (causes some UI elements to switch back to the old material design style, but this will be fixed in later Flutter releases) * BG task silently retries on network errors * Updated screenshots
Using alpha version shared in issue #14.
Obtanium downloaded all APKS flawlessly and applied their app icons, Nice!
In an attempt to mark all apps as installed I used the select all then ✅ icons. But that didn't work.
Then I performed that install all function, two apps were out of date. They now reflect in Obtanium as being on the latest version but they aren't actually updated [I assume this is just a once off Error due to the switch to the alpha version].
To remedy, I tried swipe down refresh but I got an error pop-up saying something about Null...
I restarted the app and did a refresh again with no error.
But the apps still don't detect updates so I had to remove and redownload them since the 'Mark as uninstalled' option is gone.
Once I did this they updated properly 👍
The text was updated successfully, but these errors were encountered: