AI - MVP - v1 #1
Conversation
|
|
||
| private AiConnection aiConnection = null; | ||
| private AiChat aiChat = null; | ||
|
|
There was a problem hiding this comment.
Style: Either always empty lines between variable declarations or never. Sometimes, I catch myself to mix too. However, then mostly there are JavaDoc comments the separted variables.
There was a problem hiding this comment.
This applies for every-every field?
What if I have these fields in a class:
- Logger
- Data fields
- Constants
I can't group them with new lines? And what will be the right order for this fields?
There was a problem hiding this comment.
checkstyle will tell about the order. Grouping is OK, add comments then. However, this could make the code more unreadable. Just keep one empty line between each "thing".
If reasonable, you could create a nested record class for more clearer grouping. However, in your case, this doesn't seem to be necessary.
| rebuildAiChat(); | ||
| } else { | ||
| aiConnection = null; | ||
| // QUESTION: If user chose AI but then unchooses, what should we do with the AI chat? |
There was a problem hiding this comment.
In case a user can "accidentally" disable the chat, we need to think. However, I think, it is an "informed" decision. Thus, we can just drop the chat. --> Just remove the comment line.
If we don't want to drop it, we should try to keep it: I don't know about the relation between aiConnection and aiChat.
|
|
||
| @Override | ||
| public boolean shouldShow(BibEntry entry) { | ||
| return aiPreferences.isUseAi(); |
There was a problem hiding this comment.
Next iteration: Do it similar to the "recommendation" tab. The tab is shown as default, but asks for an OK
The checkmark "modern AI technologies" is too general. Think of the GDPR which asks software vendors to be very specific what happens with their data.
Thus, move from the following tab the setting to the "Entry editor" tab, next to the "recommendations". "Show AI Tab", and ask for the OpenAI token.
In case there will be more preferences, we first add them there. If they are too much, we might move the detail AI prrefernces to the separate tab "AI".
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)