-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change mongodb-boltdb-mock deleted repo ref to new SHA #81
fix: change mongodb-boltdb-mock deleted repo ref to new SHA #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, can we get this merged?
@dselans @talpert @schigh @helios-ag @chesleybrown @endorama @unguiculus @caledhwa @chrisfjones @maxcnunes I don't know which of you have permission to merge here anymore, but this should fix a bug that's breaking this for a lot of the users here. See the bug details in #79. 🙏 help, thanks! EDIT: I also just emailed the three who appear to still work at InVision. (Chesley, Chris, and Max) |
Is this PR still needed? It looks like the repo was restored: https://github.com/zaffka/mongodb-boltdb-mock |
Yeah, the PR is still needed to fix the SHA sums, otherwise golang won't build right. (It wasn't "restored" so much as "a new repo was created with a copy of the files... and thus all the hashes are different") |
I'm going to merge this into the PR I just opened. I'm trying to add in the required build process so we can get this into Also we require our file-validation check to be passing and unfortunately this will only run on branches from within this repo (not forks). So merging it into my PR first will also run that check for us. |
Thank you so much for the quick response, @chesleybrown ! |
fixes #79