Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change mongodb-boltdb-mock deleted repo ref to new SHA #81

Merged
merged 1 commit into from Oct 18, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2022

fixes #79

@ghost ghost mentioned this pull request Oct 17, 2022
Copy link

@jdaftari-confluent jdaftari-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@codyaray codyaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, can we get this merged?

@codyaray
Copy link

codyaray commented Oct 18, 2022

@dselans @talpert @schigh @helios-ag @chesleybrown @endorama @unguiculus @caledhwa @chrisfjones @maxcnunes

I don't know which of you have permission to merge here anymore, but this should fix a bug that's breaking this for a lot of the users here. See the bug details in #79.

🙏 help, thanks!

EDIT: I also just emailed the three who appear to still work at InVision. (Chesley, Chris, and Max)

@chesleybrown
Copy link
Contributor

Is this PR still needed? It looks like the repo was restored: https://github.com/zaffka/mongodb-boltdb-mock

Screen Shot 2022-10-18 at 12 39 14 PM

@codyaray
Copy link

codyaray commented Oct 18, 2022

Yeah, the PR is still needed to fix the SHA sums, otherwise golang won't build right.

(It wasn't "restored" so much as "a new repo was created with a copy of the files... and thus all the hashes are different")

@chesleybrown chesleybrown changed the base branch from master to github-ci-workflow October 18, 2022 16:04
@chesleybrown
Copy link
Contributor

I'm going to merge this into the PR I just opened. I'm trying to add in the required build process so we can get this into master.

Also we require our file-validation check to be passing and unfortunately this will only run on branches from within this repo (not forks). So merging it into my PR first will also run that check for us.

@chesleybrown chesleybrown merged commit 8e57d37 into InVisionApp:github-ci-workflow Oct 18, 2022
@codyaray
Copy link

Thank you so much for the quick response, @chesleybrown !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uses no longer accessible dependencies
3 participants