-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check GET values are set before using #16
Comments
Second user reported within a few hours of first, and saying that it stops homepage loading - think opencart may produce an error on loading for PHP 'notices' by default. Can turn off by changing the lines in the php.ini file;
However not a good fix - better to remove the cause. |
Another user has reported. Previous comment not completely correct as the PHP error handling is overwritten by Opencart. error handling is instead set in the OC admin at system>settings>server>Display Errors: which can be set to 'no'. Definitely better to fix the root cause though! Priority fix for next release. |
Comment on opencart.com ; @InaneCoding: this should fix it
to this
That should do the trick |
Related to issue #15 |
Another user reported a "Error code: ERR_CONTENT_DECODING_FAILED" error which stops the homepage from loading (other pages okay). After looking at users logs, they have the same PHP notice on line 218 and a google search suggests an opencart bug causes this to appear as a decoding error - so this is probably the same issue. |
I will do a new minor release in the next few days including this latest commit which should fix the errors seen. |
Fixed in v1.1 release 31348b2 |
Received message from user;
The GET variable 'route' is used before checking it is set. This only causes a PHP 'notice' so shouldnt affect operation, however would be good coding practice to solve. Also noticed in my logs other places where this is happening, so look at the other places where this may be happening aswell.
The text was updated successfully, but these errors were encountered: