Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@inboxsdk/core should not inline various libraries #981

Closed
wegry opened this issue Aug 9, 2023 · 0 comments
Closed

@inboxsdk/core should not inline various libraries #981

wegry opened this issue Aug 9, 2023 · 0 comments

Comments

@wegry
Copy link
Contributor

wegry commented Aug 9, 2023

@inboxsdk/core should use something like webpack's externals. For widely used libraries like lodash, using the importing project's library versions allows updates, code sharing, and future tooling improvements (in the vein of #905) to occur down the line.

We have a a number of libraries that are currently being inlined.

[
          '@babel/runtime',
          '@macil/simple-base-converter',
          'asap',
          'auto-html',
          'bignumber.js',
          'bimapcache',
          'buffer',
          'classnames',
          'closest-ng',
          'combokeys-capture',
          'contain-by-screen',
          'ext-corb-workaround',
          'fast-deep-equal',
          'immutability-helper',
          'kefir',
          'kefir-bus',
          'kefir-cast',
          'kefir-stopper',
          'live-set',
          'lodash',
          'map-indexed-xf',
          'matches-selector-ng',
          'order-manager',
          'page-parser-tree',
          'pdelay',
          'querystring-es3',
          'react',
          'react-dom',
          'react-draggable-list',
          'react-smooth-collapse',
          'sha.js',
          'ud',
          'ud-kefir',
          'tag-tree',
          'transducers.js',
      ]

Drawbacks

#785 support. Externals make packaging code for users wanting to avoid bundlers trickier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant