This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
Incorporated @danslo HHVM totals fixes for PHP7 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mage_Sales required dependancy for PHP7 totals fix
Fix issue with discounts not being applied in PHP 7.x Full credit to @danslo - taken from Rubic_FixTotalSorting (https://github.com/danslo/Rubic_FixTotalSorting)
icurdinj
added a commit
that referenced
this pull request
Dec 18, 2015
Incorporated @danslo HHVM totals fixes for PHP7 Look like an elegant solution, and it solves an important problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.x breaks the totals calculation in Magento 1.9.x (I believe also 1.8.x), so discounts are no longer applied. This issue was raised a while ago against HHVM (facebook/hhvm#2416) and subsequently patched. The patch created by @danslo is incorporated here.
Technically this is not a PHP 7 incompatibility, but it is something that will manifest when trying to use PHP 7 with Magento 1.x, so thought it helpful to include here.