Gloria downloader #104
Merged
Gloria downloader #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like you did not format (black and isort) the pull request. You can have a look into the format_and_test.sh file on how to do that. This is a linux file, but you can copy paste the commands in cml or write your own bat file (actually, you could translate/make a format_and_test.bat similar to the sh file for convinience, just push it with a pull request when you see that it is working) |
konstantinstadler
previously requested changes
Apr 19, 2023
|
which version of black are you using for the linting?
________________________________
From: Hazim Hussein ***@***.***>
Sent: Wednesday, April 19, 2023 15:51
To: IndEcol/pymrio ***@***.***>
Cc: Konstantin Stadler ***@***.***>; Comment ***@***.***>
Subject: Re: [IndEcol/pymrio] Gloria downloader (PR #104)
@hazimhussein commented on this pull request.
________________________________
In doc/source/notebooks/advanced_group_stressors.ipynb<#104 (comment)>:
@@ -34,7 +34,7 @@
"metadata": {},
"outputs": [],
"source": [
- "wiod_folder = '/tmp/mrios/WIOD2013'"
+ "wiod_folder = \"/tmp/mrios/WIOD2013\""
This is done automatically by black
—
Reply to this email directly, view it on GitHub<#104 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABTX7S2CV2XHWFDU2VCN5R3XB7UXXANCNFSM6AAAAAAXCJUZQQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
It is 23.3.0
But black package alone didn’t work on jupyter notebook, I had to download another dependency “black-jupyter” also version 23.3.0
From: Konstantin Stadler ***@***.***>
Sent: Wednesday, April 19, 2023 4:02 PM
To: IndEcol/pymrio ***@***.***>
Cc: Hazim Hussein ***@***.***>; Mention ***@***.***>
Subject: Re: [IndEcol/pymrio] Gloria downloader (PR #104)
which version of black are you using for the linting?
________________________________
From: Hazim Hussein ***@***.***<mailto:***@***.***>>
Sent: Wednesday, April 19, 2023 15:51
To: IndEcol/pymrio ***@***.***<mailto:***@***.***>>
Cc: Konstantin Stadler ***@***.***<mailto:***@***.***>>; Comment ***@***.***<mailto:***@***.***>>
Subject: Re: [IndEcol/pymrio] Gloria downloader (PR #104)
@hazimhussein commented on this pull request.
________________________________
In doc/source/notebooks/advanced_group_stressors.ipynb<#104 (comment)>:
@@ -34,7 +34,7 @@
"metadata": {},
"outputs": [],
"source": [
- "wiod_folder = '/tmp/mrios/WIOD2013'"
+ "wiod_folder = \"/tmp/mrios/WIOD2013\""
This is done automatically by black
—
Reply to this email directly, view it on GitHub<#104 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABTX7S2CV2XHWFDU2VCN5R3XB7UXXANCNFSM6AAAAAAXCJUZQQ>.
You are receiving this because you commented.Message ID: ***@***.***<mailto:***@***.***>>
—
Reply to this email directly, view it on GitHub<#104 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AG7SFTO4BGVMDL5O3X6MZZ3XB7V43ANCNFSM6AAAAAAXCJUZQQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
konstantinstadler
dismissed
their stale review
changes have been implemented as requested, all done
konstantinstadler
approved these changes
Jun 8, 2023
pymrio/tools/iodownloader.py
Outdated
| @@ -91,6 +94,11 @@ | |||
| }, | |||
| } | |||
|
|
|||
| GLORIA_CONFIG = {"datafiles": {}} | |||
|
|
|||
| with open(os.path.join(os.path.abspath(__ROOT), "../tools/gloria_urls.json"), "r") as f: | |||
There was a problem hiding this comment.
Please put this data file in the constants.py file, make a new entry CONFIG_FILE and just put it there
There was a problem hiding this comment.
with that you can remove _ROOT then. The idea is that we dont have path specs in the code, but all gathered in constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the implementation of the GLORIA downloader and the related documentation