Skip to content
This repository has been archived by the owner on Apr 20, 2022. It is now read-only.

Investigate Set component allocations with Ledger #514

Closed
rootulp opened this issue Nov 19, 2021 · 3 comments
Closed

Investigate Set component allocations with Ledger #514

rootulp opened this issue Nov 19, 2021 · 3 comments

Comments

@rootulp
Copy link
Contributor

rootulp commented Nov 19, 2021

I'm having trouble getting the set allocations to show up when connecting my ledger.
The error I'm receiving is An operation that changes the device state is in progress.

I'm not an expert on our ledger integration. This shows up in my google search:
https://github.com/crosswalk-project/chromium-crosswalk/blob/master/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

Originally posted by @controtie in #422 (comment)

Investigate this on website-v2-master branch

@rootulp
Copy link
Contributor Author

rootulp commented Nov 21, 2021

This looks caused by https://github.com/SetProtocol/index-ui/blob/46e42c0122b02948a8a7ce1de1b5d8186caa49a8/src/utils/setjsApi.ts#L70

index-ui doesn't do proper error handling so we should add a .catch() to the function that invokes this method. set.js may also need to be updated to catch the error and propagate a stacktrace.

Screen Shot 2021-11-21 at 2 43 45 PM

Ledger wallet appears problematic for all providers that make requests to set.js (StreamingFeeProvider, TokenSupplyProvider, and SetComponentsProvider).

@rootulp
Copy link
Contributor Author

rootulp commented Nov 21, 2021

Relevant LedgerHQ/ledgerjs#607

rootulp added a commit to rootulp/index-ui that referenced this issue Nov 21, 2021
I did these upgrades to try and reoslve IndexCoop#514
They didn't resolve that issue but I think we can upgrade them anyway.
@rootulp
Copy link
Contributor Author

rootulp commented Nov 22, 2021

Created LedgerHQ/ledgerjs#718

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants