Apply async for sharedPrefs rather than committing(), which writes on the ui thread. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k on the main thread
jackie-benowitz
added a commit
that referenced
this pull request
Mar 26, 2015
Apply async for sharedPrefs rather than committing(), which writes on the ui thread.
|
Awesome -- this is a great improvement! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying shared prefs rather than committing to prevent writing to disk on the main thread. Looking at the app in strict mode, there were a lot of warnings due to disk read/write on main thread by Indicative.java, which was causing performance issues.