Refactor/anoncreds revocation move logic #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nCredsIssuer Signed-off-by: Char Howland <char@indicio.tech>
…AnonCredsIssuer Signed-off-by: Char Howland <char@indicio.tech>
Signed-off-by: Char Howland <char@indicio.tech>
burdettadam
approved these changes
May 18, 2023
dbluhm
reviewed
May 18, 2023
Comment on lines
-508
to
+512
| issuer_id: str, | ||
| cred_def_id: str, | ||
| registry_type: str, | ||
| tag: str, | ||
| max_cred_num: int, | ||
| profile, | ||
| issuer_rev_reg_record: IssuerRevRegRecord, |
There was a problem hiding this comment.
Could you help me understand the motivation for passing the issuer rev reg record instead of the individual components of issuer_id, cred_def_id, etc.?
There was a problem hiding this comment.
My motivation was that if we pass in the whole record, we can access the components that aren't directly passed in (_id, state) that previously we didn't have to pass in because the method was on the IssuerRevRegRecord itself. This seemed preferrable to adding _id and state to be retrieved from the request body and passed directly into AnonCredsIssuer.create_and_register_revocation_registry_definition(). Curious to hear your thoughts and other alternatives.
Signed-off-by: Char Howland <char@indicio.tech>
|
Stale and no longer relevant. Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
/anoncreds/revocation-registry-definitionand/anoncreds/revocation-listendpoints to call corresponding methods onAnonCredsIssuerrather thanIssuerRevRegRecord.