Issue revocable creds using anoncreds interface #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Burdett <burdettadam@gmail.com>
Signed-off-by: Adam Burdett <burdettadam@gmail.com>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
cjhowland
approved these changes
May 23, 2023
burdettadam
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes off the full issuance flow using the generic anoncreds interface. Places where the original Indy-specific components were used have been replaced with generic calls, most of which happen in the
anoncreds/issuer.pyfile. There is room for further refinement;issuer.pyis now quite long and many of the methods are specific to revocation and some of those methods are actually used by both issuer and holder. This suggests a need for anAnonCredsRevocationcomponent. This can be introduced in a follow up PR.This PR supersedes #125. Those commits are included here and were necessary to complete the full issuance flow with revocation. (Thanks, @burdettadam)
This PR (currently) conflicts with #124; I believe we can simplify the revocation logic by eliminating the
IssuerRevRegRecordandRevocationRegistryclasses (both of which had questionable value and an overloading of responsibilities). This PR represents an "MVP" that does not make use of those classes. However, there may be cause to rework and reintroduce those classes still so I'm not ruling out the changes in #124 completely (which already goes a long way towards making those classes make a whole lot more sense -- thanks, @cjhowland).