admin api for generic tails file upload #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
reviewed
May 19, 2023
Signed-off-by: Adam Burdett <burdettadam@gmail.com>
burdettadam
force-pushed
the
feature/anoncreds-upload-tailsfile
branch
from
b72608c
to
57d1e4b
Compare
Signed-off-by: Adam Burdett <burdettadam@gmail.com>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
reviewed
May 22, 2023
aries_cloudagent/anoncreds/routes.py
Outdated
| try: | ||
| issuer = AnonCredsIssuer(profile) | ||
| rev_reg_def_result = ( | ||
| await anoncreds_registry.get_revocation_registry_definition( |
There was a problem hiding this comment.
The check we're performing here should be making sure that we have the rev reg def locally so we can upload the tails file (which should also be present locally). The get_revocation_registry_definition method on the anoncreds registry retrieves a rev reg def from a remote registry though. So what I think we want is actually something more like get_created_revocation_registry_definitions, similar to the method we have for cred defs.
There was a problem hiding this comment.
Or rather, I think I was thinking of match_created_credential_definitions
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
merged commit 7d2e573
into
feature/anoncreds-revocation-again
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.