feat: add didcomm v2 service model #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
Needs some tests |
victormartinez-work
suggested changes
Feb 21, 2023
chumbert
reviewed
Feb 21, 2023
| DIDCommService = DIDCommV1Service | ||
|
|
||
|
|
||
| class DIDCommV2ServiceEndpoint(ServiceEndpoint): |
There was a problem hiding this comment.
Piggybacking on this PR because I was looking at adding a similar thing.
Since the W3C spec supports AIPs with the accept field, I think it is correct that DIDCommMessaging and the accept are valid to use for didcomm v1 services. Right ?
Maybe splitting the DIDCommService structures between the "aries flavor" of did-communication vs the W3C spec is a more sensible way to go than v1 vs v2 ?
And a minor compat correction for flake8 Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Bluhm dbluhm@pm.me