Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn - electron - lots of new features #80

Merged
merged 58 commits into from
Jan 21, 2019
Merged

yarn - electron - lots of new features #80

merged 58 commits into from
Jan 21, 2019

Conversation

blurymind
Copy link
Collaborator

@blurymind blurymind commented Sep 2, 2018

This also adds the feature of showing tags and title of active nodes:
bondagejsnodedata2

As well as fixes some code that can make easier to embed in other electron software

Tags and node titles can be used to trigger events in game, such as change of avatars or animations during cutscenes

Also updating bondage.js after I made some changes:
hylyh/bondage.js#39 (comment)
hylyh/bondage.js#40
hylyh/bondage.js#41

you can download a build here btw:
https://github.com/blurymind/Yarn/releases/tag/v0.3.2 (outdated build)

added after build:

  • Updated bondage.js to its newest version, adding new features to the story tester/debugger
  • bbcode open/close tag and "[[" autocompletion in text editor
  • preview of bbcode tag effects and goto in trimmed nodes
  • optional spell checking
  • optional autocompletion
  • optional preview bbcode in editor mode
  • a color picker (using spectrum.js) to set font color in bbcode
  • bbcode toolbar and refactor of the counter
  • new context menu
  • word autocompletion now works
  • misspelled word suggestions in the new context menu - if you have selected a misspelled word
  • common word suggestions as you type
  • nodelink suggestions as you type in the right places
  • Night mode - Toggling it will invert all the light colors which the editor currently uses
  • Added a context menu command to visit other nodes via their links in the editor and even create new ones
  • Added a command to go back to the previous edited node. If there is no previous - save and close the current one
  • the toolbar is now more compact and the counter can be collapsed
  • nspell is now used for spellchecking and suggestions and typo.js has been removed
    yarn-0 3 5-newfeatures

Nikki Lombardo and others added 3 commits June 12, 2018 10:56
@blurymind
Copy link
Collaborator Author

blurymind commented Sep 3, 2018

@charblar and @julsam requested me to unbeautify the code, which I ran beautify on in a previous commit

-That is included in this pull request

@blurymind
Copy link
Collaborator Author

@charblar can you review this please? I added some new features, merged changes from master/electron (here), updated bondage.js to the latest version

@blurymind
Copy link
Collaborator Author

you can download a build here btw:
https://github.com/blurymind/Yarn/releases/tag/v0.3.2

the linux build hasnt been tested and was cross compiled

@blurymind blurymind changed the title update bondage.js to allow to get tags/titles and other node data update bondage.js to allow to get tags/titles and other node data + fix #78 Nov 24, 2018
@blurymind
Copy link
Collaborator Author

fixed #78

@blurymind blurymind changed the title update bondage.js to allow to get tags/titles and other node data + fix #78 update bondage.js to allow to get tags/titles and other node data + fix #78 , #83 Nov 24, 2018
@blurymind
Copy link
Collaborator Author

fixed #83

@blurymind blurymind changed the title update bondage.js to allow to get tags/titles and other node data + fix #78 , #83 update bondage.js to allow to get tags/titles and other node data + fix issues in #83 Nov 24, 2018
@blurymind
Copy link
Collaborator Author

reverted fix for #78 as it is already in another pull here: #79

@blurymind blurymind changed the title update bondage.js to allow to get tags/titles and other node data + fix issues in #83 update bondage.js to allow to get tags/titles and other node data + fix issues in #83 + add bbcode/other preview in trimmed nodes Nov 28, 2018
@blurymind
Copy link
Collaborator Author

added new bbcode and [[ autocompletion features + bb format preview features

@blurymind
Copy link
Collaborator Author

replaced typo.js with nspell -as typo.js hasnt seen an update in over 3 years, it has a serious delay on some word suggestions and is much less maintained. Made pull here too
swenson/ace_spell_check_js#4

@blurymind
Copy link
Collaborator Author

I think I'm getting closer to a milestone on this. Will do a bit of re-factoring and testing, then do another build

@blurymind blurymind changed the title update bondage.js to allow to get tags/titles and other node data + fix issues in #83 + add optional bbcode/other preview and autocompletion + add optional spell checking + autocompletion, add night mode, add context menu and correction suggestions yarn - electron - lots of new features Dec 31, 2018
@blurymind
Copy link
Collaborator Author

blurymind commented Jan 19, 2019

well anyways, if nobody is maintaining this repository, I might have to make my fork of this project a new project. :)

@julsam has added node resizing and fixed a bug, so I want to get his changes into my fork, but his pull is still not being reviewed either

@desplesda
Copy link
Collaborator

I’ll review this in the next 48h!

@desplesda
Copy link
Collaborator

This is really, really good.

When should we consider merging this into master?

@desplesda desplesda merged commit 1104916 into InfiniteAmmoInc:electron Jan 21, 2019
@blurymind
Copy link
Collaborator Author

blurymind commented Jan 21, 2019 via email

@desplesda
Copy link
Collaborator

desplesda commented Jan 21, 2019 via email

@lazerwalker
Copy link

lazerwalker commented Jan 21, 2019

Just to chime in on the CI server front, this is something I'm dealing with right now for https://github.com/lazerwalker/tracery-dot-app.

For Windows builds, you want Appveyor or Azure Pipelines; Travis CI's Windows setup is slow and flaky. You can check out Tracery.app's Appveyor config file, although my deployment setup is a bit different from yours since I'm using electron-forge/electron-builder to manage that instead of vanilla Electron. It's set up really nicely to automatically upload a new prerelease binary to the GitHub 'releases' section of the repo every time code is pushed/merged.

I'm still figuring out how to properly generate macOS builds on CI (since you ideally need to both codesign and notarize builds to avoid users needing to jump through onerous "this app is dangerous!" security hoops), but the data I've gathered so far suggests CircleCI is going to be the simplest way to configure a CI setup that can properly codesign/notarize given proper credentials.

@blurymind
Copy link
Collaborator Author

I made some builds here, but they are only for windows
https://github.com/blurymind/Yarn/releases/tag/0.3.5

server builds would be fantastic to have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants