-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No connections are drawn when opening a Yarn file #78
Comments
Thank you for your reporting this bug 👍 It seems like the issue comes from the line ending. When using the yarn.txt save format, Yarn is expecting only Unix type line ending and doesn't interpret correctly CR that Windows add. By default Yarn saves using LF only, but I guess the text editor you used changed it to CRLF. Should be easy to fix, but in the meantime you can convert your files from the Windows format to the Unix one and the connections should be back 😉 Another quickfix would be to save it as a json file. |
When loading a yarn.txt file, Yarn was expecting lines to end only with \n and didn't handle properly lines ending with \r\n. Yarn saves files using only \n, even on Windows, but if the user modify the file manually, some editors on Windows will convert \n to \r\n, so it must be taken into account.
Thanks for the great info and the source of the problem. Thank you! :-) |
Fix for issue #78 loading yarn.txt with \r\n lines
Fixed in c50b77c. |
So I noticed that this fix doesn't seem to be included in Yarn-master somehow when you download the ZIP from Git. I opened up data.js and added the fix manually, but it doesn't seem to work. |
Please attach the example file :)
…On Fri, Apr 12, 2019, 2:29 AM swakdaddy ***@***.***> wrote:
So I noticed that this fix doesn't seem to be included in Yarn-master
somehow when you download the ZIP from Git. I opened up data.js and added
the fix manually, but it doesn't seem to work.
Dumb question, but do I need to compile something to get it to work?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGMbVTlQ_SndNiVaaXSIxbN1RV65IIRVks5vf-GIgaJpZM4WLhMz>
.
|
The example file is already attached in the original post. See Sally.yarn.txt above. If you are talking about data.js, I simply changed the line in this change list to match what is supposed to be in git. It does not work locally by changing that file and then running Yarn by dragging Yarn-master folder into nw.exe. It's the only way I've found to run latest version of Yarn. |
@swakdaddy this was fixed on the electron branch. You need to use that instead of master |
@blurymind - Ah thanks. I'll grab the electron branch then since it seems you guys have been working more on it! |
It has alot of the issues here fixed, it's just not the default branch yet
for some reason
…On Thu, Apr 18, 2019, 4:51 PM swakdaddy ***@***.***> wrote:
@blurymind <https://github.com/blurymind> - Ah thanks. I'll grab the
electron branch then since it seems you guys have been working more on it!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABRRWVKOOO5GNZ26772A7Q3PRCKG7ANCNFSM4FROCMZQ>
.
|
OS: Windows 10.
Repro steps:
Including a file I know isn't working.
Thanks!
Sally.yarn.txt
The text was updated successfully, but these errors were encountered: