fix

InfinityBotList · Apr 27, 2024 · 0577c47 · 0577c47
1 parent 763d65f
commit 0577c47
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/routes/teams/endpoints/edit_team_member/route.go b/routes/teams/endpoints/edit_team_member/route.go
@@ -106,7 +106,7 @@ func Route(d uapi.RouteData, r *http.Request) uapi.HttpResponse {
 
 	defer tx.Rollback(d.Context)
 
-	if len(payload.Perms) != 0 {
+	if payload.Perms != nil {
 		if !kittycat.HasPerm(managerPerms, kittycat.Build("team_member", teams.PermissionEdit)) {
 			return uapi.HttpResponse{
 				Status: http.StatusForbidden,
@@ -126,7 +126,7 @@ func Route(d uapi.RouteData, r *http.Request) uapi.HttpResponse {
 		}
 
 		// Perform initial checks
-		for _, perm := range payload.Perms {
+		for _, perm := range *payload.Perms {
 			if !teams.IsValidPerm(perm) {
 				return uapi.HttpResponse{
 					Status: http.StatusBadRequest,
@@ -140,7 +140,7 @@ func Route(d uapi.RouteData, r *http.Request) uapi.HttpResponse {
 		// Right now, we use perm overrides for this
 		// as we do not have a hierarchy system yet
 		newPermsResolved := kittycat.StaffPermissions{
-			PermOverrides: payload.Perms,
+			PermOverrides: *payload.Perms,
 		}.Resolve()
 
 		// First ensure that the manager can set these permissions

diff --git a/types/teams.go b/types/teams.go
@@ -88,9 +88,9 @@ type AddTeamMember struct {
 }
 
 type EditTeamMember struct {
-	Perms       []string `json:"perms" description:"The permissions to set. If empty, will not update"`
-	Mentionable *bool    `json:"mentionable" description:"Whether the user is mentionable Whether the user is mentionable (for alerts in bot-logs etc.)"`
-	DataHolder  *bool    `db:"data_holder" json:"data_holder" description:"Whether the user is a data holder responsible for all data on the team. That is, should performing mass-scale operations on them affect the team"`
+	Perms       *[]string `json:"perms" description:"The permissions to set. If empty, will not update"`
+	Mentionable *bool     `json:"mentionable" description:"Whether the user is mentionable Whether the user is mentionable (for alerts in bot-logs etc.)"`
+	DataHolder  *bool     `db:"data_holder" json:"data_holder" description:"Whether the user is a data holder responsible for all data on the team. That is, should performing mass-scale operations on them affect the team"`
 }
 
 type UserEntityPerms struct {