migrated to androidx #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Sep 21, 2018
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 4.0.0 (21.8.2018) | |||
There was a problem hiding this comment.
Leave this out for now, maintainers will update the changelog when a new release is made
| compile 'com.android.support:appcompat-v7:24.0.0' | ||
| implementation project(':calligraphy') | ||
| // implementation 'io.github.inflationx:viewpump:1.0.0' | ||
| implementation 'com.github.kibotu:ViewPump:v2.0.0' |
| @@ -37,14 +36,16 @@ public void run() { | |||
| }, 1000); | |||
|
|
|||
| handler.postDelayed(new Runnable() { | |||
| @Override public void run() { | |||
| @@ -23,19 +25,19 @@ public static Fragment getInstance() { | |||
| } | |||
|
|
|||
| @Override | |||
| public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle state) { | |||
| public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle state) { | |||
There was a problem hiding this comment.
This project assumes nonnull is the default, please only use nullable annotations as needed
|
|
||
| /** | ||
| * Created by chris on 17/03/15. | ||
| * For Calligraphy. | ||
| */ | ||
| public class TextField extends TextView { | ||
| public class TextField extends AppCompatTextView { |
| jcenter() | ||
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.2.1' | ||
| classpath 'com.android.tools.build:gradle:3.3.0-alpha11' | ||
| classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1' |
| jcenter() | ||
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.2.1' | ||
| classpath 'com.android.tools.build:gradle:3.3.0-alpha11' |
| ext { | ||
| isReleaseVersion = has("release") | ||
| versionCodeInt = getProperty('VERSION_CODE').toInteger() | ||
| } | ||
| } | ||
|
|
||
| task wrapper(type: Wrapper) { |
| } | ||
| } | ||
|
|
||
| allprojects { | ||
| repositories { | ||
| maven { url 'https://jitpack.io' } |
| } | ||
|
|
||
| apply from: rootProject.file('gradle/deploy.gradle') | ||
| //apply from: rootProject.file('gradle/deploy.gradle') |
|
Thanks for your contribution! I've made the changes for the comments that were requested and have merged it manually into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.