Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DD notebook to include strategies #770

Merged
merged 38 commits into from
Nov 1, 2023
Merged

Update DD notebook to include strategies #770

merged 38 commits into from
Nov 1, 2023

Conversation

paaige
Copy link
Contributor

@paaige paaige commented Sep 14, 2023

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@paaige
Copy link
Contributor Author

paaige commented Sep 14, 2023

I'm still seeing an issue on all of the static methods (they are applying DD after measurement). This is the static method on a 2 qubit BV circuit, seeing similar on SCA for larger circuits.

BV_2_static

@knsmith
Copy link
Contributor

knsmith commented Sep 15, 2023

I'm still seeing an issue on all of the static methods (they are applying DD after measurement). This is the static method on a 2 qubit BV circuit, seeing similar on SCA for larger circuits.

BV_2_static

Summary of dev meeting discussion: DD is scheduled on all qubits, and it's appearing on q1 while q0 is being measured. Unfortunately, drawing the circuit using qiskit doesn't give context with respect to the duration of the measurement. Qiskit's timeline_drawer would be a better tool to get a sense of timing.

Perhaps a solution that would create a nicer circuit would be to use a different circuit (GHZ was also a nice one - I think we had this in an earlier version of this notebook) or to place a measurement operation on all qubits?

@knsmith
Copy link
Contributor

knsmith commented Sep 18, 2023

IMO we should have 2 notebooks: one DD user test and a second notebook that goes into greater detail about strategies.

It would also be good to emphasize that Superstaq compilation inserts DD by default. We state that dynamic is the default technique but it would be good for users to know that DD will always be invoked unless dynamical_decoupling = False

@@ -0,0 +1,376 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could make this more specific? Such as "IBM Dynamical Decoupling Strategies with Superstaq"?


Reply via ReviewNB

docs/source/optimizations/ibm/ibmq_dd_advanced.ipynb Outdated Show resolved Hide resolved
docs/source/optimizations/ibm/ibmq_dd_advanced.ipynb Outdated Show resolved Hide resolved
docs/source/optimizations/ibm/ibmq_dd_advanced.ipynb Outdated Show resolved Hide resolved
docs/source/optimizations/ibm/ibmq_dd_advanced.ipynb Outdated Show resolved Hide resolved
@paaige paaige requested a review from knsmith October 17, 2023 19:28
@paaige
Copy link
Contributor Author

paaige commented Oct 19, 2023

Waiting on #824 to merge before this goes in

@knsmith
Copy link
Contributor

knsmith commented Oct 24, 2023

This looks pretty much good to go! A few more minor comments:

  • Small nit: superstaq -> Superstaq in the intro paragraph.

  • Optional change: "All of the above strategies, by default, use the CPMG sequence. " -> "All of the above strategies, by default, use the CPMG, or XX, sequence."

  • Don't forget to remove remote_host="https://127.0.0.1:5000"

  • This will be fixed when the notebook is re-run, but right now, it looks like the last two circuits produce ghz states of different sizes

Copy link
Contributor

@knsmith knsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor nits.

@paaige paaige requested a review from knsmith October 25, 2023 07:00
@knsmith
Copy link
Contributor

knsmith commented Oct 26, 2023

The second to last cell might need to be rerun since the default dd_strategy is now static_context_aware - I guess the intro paragraph should be updated as well...

Other than that, it looks good to go!

Copy link
Contributor

@knsmith knsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M !(once we determine why notebook checks are failing...)

@paaige
Copy link
Contributor Author

paaige commented Oct 28, 2023

LG2M !(once we determine why notebook checks are failing...)

I had to switch from using guadalupe to perth

@paaige paaige removed the request for review from dowusu-antwi October 28, 2023 06:34
@paaige paaige merged commit f601092 into main Nov 1, 2023
16 checks passed
@paaige paaige deleted the update_dd_nb branch November 1, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants