Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set timeout on Hilbert submission daily integration test to 5 minutes #800

Merged
merged 3 commits into from
Oct 1, 2023

Conversation

vtomole
Copy link
Member

@vtomole vtomole commented Oct 1, 2023

Hotfix for now. We probably want to put this as a separate test longterm so a different issue will be made by the bot when the test fails.

@vtomole vtomole changed the title Set timeout on Hilbert submission daily integration test Set timeout on Hilbert submission daily integration test to 5 minutes Oct 1, 2023
Copy link
Collaborator

@perlinm perlinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about 5 vs 15 min

@@ -12,6 +12,7 @@ jobs:
env:
SUPERSTAQ_API_KEY : ${{ secrets.SUPERSTAQ_API_KEY }}
runs-on: ubuntu-latest
timeout-minutes: 15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 min instead of 15?

Copy link
Member Author

@vtomole vtomole Oct 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 minutes for the individual Hilbert test and 15 for the whole suite. The 15 is added cause we mistakenly believed that opensource Github actions didn't cost 😅 . I'm gonna guess it starts to cost when your jobs run too long or something. Something to look into.

@vtomole vtomole merged commit 8cc614d into main Oct 1, 2023
16 checks passed
@vtomole vtomole deleted the timeout_hilbert_submission branch October 1, 2023 22:19
bharat-thotakura pushed a commit that referenced this pull request Oct 5, 2023
…#800)

Hotfix for now. We probably want to put this as a separate test longterm
so a different issue will be made by the bot when the test fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants