Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs readme #876

Merged
merged 18 commits into from
Jan 29, 2024
Merged

update docs readme #876

merged 18 commits into from
Jan 29, 2024

Conversation

paaige
Copy link
Contributor

@paaige paaige commented Jan 9, 2024

Closes #863

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@paaige paaige changed the title update readme docs update docs readme Jan 9, 2024
@paaige
Copy link
Contributor Author

paaige commented Jan 9, 2024

also do we still need docs/Makefile? it only really executes one command, which we could just put in build_docs.py (or alternatively we could move all the sphinx-apidoc calls from build_docs to the makefile?)

Just noticed this comment from the issue, i'll update wrt it

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review: changes LGTM (pending pandocs -> pandoc).

Will leave final approval to @stephanielee9 or @richrines1

@paaige
Copy link
Contributor Author

paaige commented Jan 19, 2024

also do we still need docs/Makefile? it only really executes one command, which we could just put in build_docs.py (or alternatively we could move all the sphinx-apidoc calls from build_docs to the makefile?)

Moved to build_docs and removed the makefile

checks-superstaq/checks_superstaq/build_docs.py Outdated Show resolved Hide resolved
if sphinx_paths:
for path in sphinx_paths:
subprocess.run(
f"sphinx-apidoc -f -o source {path} {path}/*_test.py", shell=True, cwd=docs_dir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should turn this into a list and remove the shell=True:

Suggested change
f"sphinx-apidoc -f -o source {path} {path}/*_test.py", shell=True, cwd=docs_dir
["sphinx-apidoc", "-f" ,"-o", "source", path, f"{path}/*_test.py"], cwd=docs_dir

also should we add the "-W" option so the check fails on warnings? (and ditto for the sphinx-build line below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a flag for sphinx-apidoc but will add it for the build command

checks-superstaq/checks_superstaq/build_docs.py Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
paaige and others added 10 commits January 22, 2024 12:09
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm % formatting! leaving for @stephanielee9 for final approval though because she's more familiar with the docs infrastructure

Copy link
Contributor

@stephanielee9 stephanielee9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! from what I can tell, the docs still build locally fine with the make file and readthedocs doesn't use it either

@paaige paaige merged commit 8b7c698 into main Jan 29, 2024
16 checks passed
@paaige paaige deleted the docs_rm branch January 29, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs readme is out of date
4 participants