-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up notebook check #892
Conversation
f2c02af
to
b705c06
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
notebook format
20bf9f4
to
49237f6
Compare
Reminder: #752 |
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm! when you're ready to merge we can switch the github rules to the new set of checks
thanks for updating this :)
Thanks! I'm good to merge this but also opened #893 as a brief solution (and also an attempt to begin the |
Updates some of the notebooks (and possibly dependent files) to have clearer `qss` and `css` variants. Motivated by #892 (comment), this PR should ideally remove the necessity of the 'Notebook check for other docs' in #892 for now (see #892 (comment))
Update: With #893 merged, this PR has been updated to only have the 'Notebook check for qiskit/cirq-superstaq' cc: @vtomole @richrines1 |
updated the requirements, so should be good to merge! given that the checks still takes a while there might be an argument for splitting "supermarq" off into its own category down the line... |
^ I'm hoping the resolution to #772 would void the need for a further update since 'Notebook check for cirq-superstaq' finishes much faster and the cause seems to be the call to |
ahh yep that makes sense |
Made some interim changes with 1f953b0 that should hopefully cut down the |
Interim test for #889
(Also re-runs some notebooks for updated target outputs and adds the
available=True
flag in_HPCA_Tutorial.ipynb
)