-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for qiskit
1.0
#906
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the 1.0.0 pin necessary? it seems like all of the changes in this pr would be compatible with qiskit>=0.45.0
, and the linked upgrading issues shouldn't matter if e.g. someone has 0.45.1 and wants to stay on that version
(we definitely do have to drop 0.44.*
though because the qiskit.extensions gates weren't moved until 0.45.0
)
client-superstaq/qiskit-superstaq/qiskit_superstaq/serialization.py Lines 114 to 117 in 3ab6c9c
qiskit.qpy.dump(circuits, buf, version=qiskit.qpy.common.QPY_COMPATIBILITY_VERSION) . But version was only added in 1.0.0 so it may cause issues for users with qiskit 0.45.1. If not, I think you're right that we should support qiskit>=0.45.0 .Edit: Looks like my concerns can be addressed by bumping to |
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Adds the bare minimum changes needed to support running
qiskit
1.0.0Changes in this PR:
qiskit >= 0.45.0
per commentQuantumCircuit.qasm
per https://docs.quantum.ibm.com/api/migration-guides/qiskit-1.0-features#quantumcircuitqasmqiskit.extensions
per https://docs.quantum.ibm.com/api/migration-guides/qiskit-1.0-features#qiskitextensions