Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qubovert requirement #910

Merged
merged 6 commits into from
Feb 24, 2024
Merged

Remove qubovert requirement #910

merged 6 commits into from
Feb 24, 2024

Conversation

bharat-thotakura
Copy link
Contributor

@bharat-thotakura bharat-thotakura commented Feb 23, 2024

Removes the qubovert requirement in gss as it was primarily used for typing purposes. It should be an optional install for users like in the MIS notebook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bharat-thotakura bharat-thotakura changed the title Remove qubovert requirement Remove qubovert requirement Feb 23, 2024
@bharat-thotakura bharat-thotakura marked this pull request as ready for review February 23, 2024 14:35
Copy link
Member

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add __future__ import

typing update

add type hint for css
@bharat-thotakura bharat-thotakura merged commit 0733c56 into main Feb 24, 2024
17 checks passed
@bharat-thotakura bharat-thotakura deleted the move_qubovert_usage branch February 24, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants