Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up qubo interface and fix tests #918

Merged
merged 12 commits into from
Mar 7, 2024
Merged

clean up qubo interface and fix tests #918

merged 12 commits into from
Mar 7, 2024

Conversation

richrines1
Copy link
Contributor

@richrines1 richrines1 commented Mar 7, 2024

  • moves result deserialization into service.submit_qubo(), so the user doesn't have to manually call read_json_qubo_result() on the result (this is what we do for every other endpoint)
  • removes gss.qubo (currently this only contains read_json_qubo_result(), which can be replaced with a single line in gss.Service)
  • removes hard-coded target validation in submit_qubo (which is currently tied to testing code)
  • fixes various minor testing issues
  • adds gss.validation.validate_qubo to validate qubo inputs

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment on lines 166 to 168
repetitions: int = 1000,
method: str | None = None,
max_solutions: int = 1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The utility of max_solutions may need to be re-evaluated in light of updates (related to #914), but I think its fine as far as the scope of this PR is concerned

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@richrines1 richrines1 merged commit 0531504 into main Mar 7, 2024
18 checks passed
@richrines1 richrines1 deleted the fix-tests branch March 7, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants